Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts: use default babel if none is found in project #14168

Merged
merged 19 commits into from
Mar 14, 2019
Merged

Scripts: use default babel if none is found in project #14168

merged 19 commits into from
Mar 14, 2019

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Feb 28, 2019 •
edited
Loading

Changes to make Webpack use the @wordpress/babel-preset-default babel config if none is found when running wp-scripts build/start.

Test

  • make sure you can build Gutenberg for development: npm run dev and that it works as expected.
  • make sure you can build Gutenberg for production: npm run build and that it works as expected.
  • external testbed using the default babel config Add/wp scripts babel oandregal/understanding-gutenberg#7

@oandregal oandregal changed the title Add/babel to scripts Scripts: use default babel if none is found in project Feb 28, 2019
@oandregal oandregal self-assigned this Feb 28, 2019
@oandregal oandregal added [Type] Build Tooling Issues or PRs related to build tooling [Package] Scripts /packages/scripts labels Feb 28, 2019
gziolo
gziolo reviewed Mar 4, 2019
View reviewed changes
packages/scripts/config/webpack.config.js Outdated Show resolved Hide resolved
packages/babel-preset-default/index.js Outdated Show resolved Hide resolved
@oandregal oandregal force-pushed the add/defaults-to-scripts-build branch from b9f6973 to 6da9e92 Compare March 11, 2019 12:15
@oandregal oandregal changed the base branch from add/defaults-to-scripts-build to master March 12, 2019 12:18
@oandregal oandregal marked this pull request as ready for review March 12, 2019 12:19
@oandregal oandregal requested a review from gziolo March 12, 2019 12:19
gziolo
gziolo reviewed Mar 13, 2019
View reviewed changes
bin/packages/build.js Show resolved Hide resolved
packages/babel-preset-default/index.js Show resolved Hide resolved
packages/babel-preset-default/index.js Show resolved Hide resolved
packages/babel-preset-default/index.js Show resolved Hide resolved
@oandregal oandregal force-pushed the add/babel-to-scripts branch 3 times, most recently from 2dcc4e0 to eb88287 Compare March 14, 2019 09:38
@oandregal oandregal requested a review from gziolo March 14, 2019 12:28
gziolo
gziolo reviewed Mar 14, 2019
View reviewed changes
test/unit/jest.config.json Outdated Show resolved Hide resolved
@gziolo gziolo mentioned this pull request Mar 14, 2019
Merged
@oandregal oandregal requested a review from gziolo March 14, 2019 15:11
@oandregal
Teach babel-preset-default where to lookup for deps
0fa9328
@oandregal
Centralize babel logic in preset
c165b3a
@oandregal
Use api.caller instead of env variables
fcf15b4
@oandregal
Refactor checks
b71ed56
@oandregal
Changes from rebase
1ddea86
@oandregal
Update how browserslist-config package is looked up
fe42762 
It is only used by babel-preset-default. It is looked up by require
itself so we need to tell Jest not to substitute with anything.
@oandregal
Update comment
b52c127
@oandregal
Fix browserslist-config dep
4533479
@oandregal
Simplify which code changes
f137cfa
@oandregal
The babel cache uses the api.caller
704f61f 
So we don't need to update it manually.
@oandregal
Be explicit about cache keys
2c86a81
@oandregal
Do not use any config file if we provide the config
7dc2785
@oandregal
Add .babelrc.js file to the list of valid babel configs
a9ab1f4 
See https://babeljs.io/docs/en/config-files#file-relative-configuration
@oandregal
Delete filed added in rebase
72b4f7d
gziolo
gziolo reviewed Mar 14, 2019
View reviewed changes
packages/scripts/utils/config.js
@@ -7,6 +7,7 @@ const { hasPackageProp } = require( './package' );

const hasBabelConfig = () =>
hasProjectFile( '.babelrc' ) ||
hasProjectFile( '.babelrc.js' ) ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

@oandregal
Remove node_modules from packages.
a60bc06 
Individual packages shouldn't have node_modules installed in
their local paths in a normal Gutenberg operation. Yet,
if you `cd packages/<packagename> && npm install` things start
going south - like tests not passing.
gziolo
gziolo approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it very extensively and it all works perfectly fine. Thi is AMAZING. Outstanding work on making it all work!!!

🥇 💯 🚀

@gziolo gziolo added this to the 5.3 (Gutenberg) milestone Mar 14, 2019
@oandregal oandregal mentioned this pull request Mar 14, 2019
Merged
@oandregal oandregal merged commit 244d7ce into master Mar 14, 2019
@oandregal oandregal deleted the add/babel-to-scripts branch March 14, 2019 17:51
This was referenced Mar 18, 2019
Merged
Merged
Closed
Closed
youknowriad pushed a commit that referenced this pull request Mar 20, 2019
@nosolosw @youknowriad
Scripts: use default babel if none is found in project (#14168)
e355de5
youknowriad pushed a commit that referenced this pull request Mar 20, 2019
@nosolosw @youknowriad
Scripts: use default babel if none is found in project (#14168)
4b344be
@chrisvanpatten chrisvanpatten mentioned this pull request Jul 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@mkaz mkaz Awaiting requested review from mkaz

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@oandregal oandregal

Labels
[Package] Scripts /packages/scripts [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
5.3 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
2 participants
@oandregal @gziolo